-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading playlist improvements #7127
Open
smithjd15
wants to merge
9
commits into
clementine-player:master
Choose a base branch
from
smithjd15:loadplMissingEntries
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Loading playlist improvements #7127
smithjd15
wants to merge
9
commits into
clementine-player:master
from
smithjd15:loadplMissingEntries
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithjd15
force-pushed
the
loadplMissingEntries
branch
from
November 26, 2021 02:06
a286ca7
to
41178a8
Compare
smithjd15
force-pushed
the
loadplMissingEntries
branch
2 times, most recently
from
January 1, 2022 05:05
e44ae55
to
06d92de
Compare
smithjd15
force-pushed
the
loadplMissingEntries
branch
from
March 16, 2022 04:55
06d92de
to
8d9e162
Compare
smithjd15
changed the title
Playlist Parsers: Parse all (even invalid) playlist entries.
Playlist Parser: Keep unfound entries, prioritize library entry metadata over playlist. Set entries grey when loading a playlist.
Mar 16, 2022
Closes #7135. |
Closes #5239. |
smithjd15
force-pushed
the
loadplMissingEntries
branch
3 times, most recently
from
March 18, 2022 02:41
b4002c1
to
2e7ce3b
Compare
smithjd15
changed the title
Playlist Parser: Keep unfound entries, prioritize library entry metadata over playlist. Set entries grey when loading a playlist.
Loading playlist improvements
Mar 19, 2022
smithjd15
force-pushed
the
loadplMissingEntries
branch
from
March 28, 2022 02:40
2e7ce3b
to
e1d4ef1
Compare
smithjd15
force-pushed
the
loadplMissingEntries
branch
2 times, most recently
from
November 19, 2022 23:35
69780b4
to
fccf0f0
Compare
smithjd15
force-pushed
the
loadplMissingEntries
branch
from
November 19, 2022 23:37
fccf0f0
to
df45e6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset is part two of three of a series to improve Clementine's creation and maintenance of (portable) playlists.
Keep unfound entries instead of silently dropping them when parsing playlists. Immediately grey unfound entries on playlist load (if enabled in the preferences) to indicate such entries. Finally, fix missing display information for loaded playlist targets found in the library by prioritizing library over playlist information.