Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading playlist improvements #7127

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

smithjd15
Copy link
Contributor

@smithjd15 smithjd15 commented Nov 26, 2021

This patchset is part two of three of a series to improve Clementine's creation and maintenance of (portable) playlists.

Keep unfound entries instead of silently dropping them when parsing playlists. Immediately grey unfound entries on playlist load (if enabled in the preferences) to indicate such entries. Finally, fix missing display information for loaded playlist targets found in the library by prioritizing library over playlist information.

@smithjd15 smithjd15 force-pushed the loadplMissingEntries branch from a286ca7 to 41178a8 Compare November 26, 2021 02:06
@smithjd15 smithjd15 force-pushed the loadplMissingEntries branch 2 times, most recently from e44ae55 to 06d92de Compare January 1, 2022 05:05
@smithjd15 smithjd15 force-pushed the loadplMissingEntries branch from 06d92de to 8d9e162 Compare March 16, 2022 04:55
@smithjd15 smithjd15 changed the title Playlist Parsers: Parse all (even invalid) playlist entries. Playlist Parser: Keep unfound entries, prioritize library entry metadata over playlist. Set entries grey when loading a playlist. Mar 16, 2022
@smithjd15
Copy link
Contributor Author

Closes #7135.

@smithjd15
Copy link
Contributor Author

Closes #5239.

@smithjd15 smithjd15 force-pushed the loadplMissingEntries branch 3 times, most recently from b4002c1 to 2e7ce3b Compare March 18, 2022 02:41
@smithjd15 smithjd15 changed the title Playlist Parser: Keep unfound entries, prioritize library entry metadata over playlist. Set entries grey when loading a playlist. Loading playlist improvements Mar 19, 2022
@smithjd15 smithjd15 force-pushed the loadplMissingEntries branch from 2e7ce3b to e1d4ef1 Compare March 28, 2022 02:40
@smithjd15 smithjd15 force-pushed the loadplMissingEntries branch 2 times, most recently from 69780b4 to fccf0f0 Compare November 19, 2022 23:35
@smithjd15 smithjd15 force-pushed the loadplMissingEntries branch from fccf0f0 to df45e6e Compare November 19, 2022 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant