Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File listing is inconsistent with folder breadcrumb after reverting changes #975

Open
qtomlinson opened this issue Apr 22, 2022 · 0 comments

Comments

@qtomlinson
Copy link
Collaborator

qtomlinson commented Apr 22, 2022

Repro step:

  1. Make a change to a component, e.g. change the declared license in https://dev.clearlydefined.io/definitions/npm/npmjs/@typescript-eslint/types/5.19.0
  2. Go to "Files" tab, click to drill down on "package" directory, the only item listed. Files are listed correctly for package directory (4 items) and the folder bread crumb is correct (types-5.19.0/package).
  3. Click on "Revert" button and "OK" to revert changes done in Step 1.
    Expected: file listing should not change (still 4 items) corresponding to the folder breadcrumb (types-5.19.0/package)
    Observed: The file listing changed, displaying only "package" folder; whereas the folder breadcrumb still correctly reflects the drill down state (types-5.19.0/package).

Before revert:
image
After revert:
image

qtomlinson added a commit to qtomlinson/website that referenced this issue Apr 22, 2022
The files state should only be modiified when directory is changed (onDirectorySelect)  or clicking breadcrumbs (onBreadcrumbSelect)

clearlydefined#975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant