Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change calling sequence of fortran solvers #17

Open
rjleveque opened this issue Oct 2, 2012 · 1 comment
Open

Change calling sequence of fortran solvers #17

rjleveque opened this issue Oct 2, 2012 · 1 comment

Comments

@rjleveque
Copy link
Member

Changes to the Riemann solvers agreed on in May but not yet implemented...

On Thu, May 31, 2012 at 5:01 PM, Randall John LeVeque [email protected] wrote:

Aron and I just went through the Riemann solvers and are considering
the following changes...

For now stick with mx, etc. and use maux instead of num_aux.

Get rid of maxm in calling sequences: this is no longer needed since
the cell variable is the last index.

Reorder parameters to e.g:
subroutine rpn2(ixy,mx,meqn,mwaves,maux,mbc,ql,qr, &
auxl,auxr,wave,s,amdq,apdq)

Declare ql,qr,auxl,auxr as intent(in) (and convert dimension
statements to f90 more generally)

Change order of rpt2 parameters to
subroutine rpt2(ixy,imp,mx,meqn,mwaves,maux,mbc,ql,qr, &
aux1,aux2,aux3,imp,asdq,bmasdq,bpasdq)

to move imp up to position 2.

A couple related changes in 3d.

mandli added a commit to mandli/riemann that referenced this issue Nov 9, 2012
Add Clawapps support and fix missing project error
@ketch
Copy link
Member

ketch commented Jul 12, 2014

Change order of rpt2 parameters to
subroutine rpt2(ixy,imp,mx,meqn,mwaves,maux,mbc,ql,qr, &
aux1,aux2,aux3,imp,asdq,bmasdq,bpasdq)
to move imp up to position 2.

This has been done.

We still need to:

  1. Remove maxm.
  2. Use intent statements and F90 declarations

maojrs pushed a commit to maojrs/riemann that referenced this issue Mar 19, 2015
Update Paths and `data` modules for multilayer and surge app examples
maojrs pushed a commit to maojrs/riemann that referenced this issue Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants