Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple topofiles at the same resolution #490

Open
rjleveque opened this issue Dec 15, 2020 · 0 comments
Open

multiple topofiles at the same resolution #490

rjleveque opened this issue Dec 15, 2020 · 0 comments

Comments

@rjleveque
Copy link
Member

If multiple topofiles are specified at different resolutions, then when computing cell integrals to determine the GeoClaw topo value in each cell, the finest resolution topofile will be used at each point. (Based on piecewise bilinear functions defined over the extent of each topofile.)

If two topofiles have the same resolution then which one is used in regions of overlap? This could be important if you have an improved version that covers only a subset of an earlier version.

Based on the logic in subroutine read_topo_settings of geoclaw/src/2d/shallow/topo_module.f90, it looks like the one that is listed last in setrun.py would be the one used by default. However, checking the resolution involves comparing two floating point areas computed by dxtopo*dytopo, and I think rounding error could make this behave in unexpected ways if the resolutions are "the same". It would be better to check if they are equal within some tolerance, and make sure we understand and are consistent about what order they are then used in.

We should also add something to the documentation about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant