Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chemspill for sec-high [M1410106] #451

Closed
classilla opened this issue Nov 29, 2017 · 7 comments
Closed

Chemspill for sec-high [M1410106] #451

classilla opened this issue Nov 29, 2017 · 7 comments

Comments

@classilla
Copy link
Owner

classilla commented Nov 29, 2017

We are vulnerable.
Preparing 45.13.1 (FPR 4 SPR 1)
Patched in 52.5.1

@classilla
Copy link
Owner Author

Also incorporating the vmx_strchr() fix from #440.

@classilla
Copy link
Owner Author

@classilla
Copy link
Owner Author

(and all its deps, dammit)

@classilla
Copy link
Owner Author

We could just implement

+void
+OriginAttributes::SyncAttributesWithPrivateBrowsing(bool aInPrivateBrowsing)
+{
+  mPrivateBrowsingId = aInPrivateBrowsing ? 1 : 0;
+}

in caps/BasePrincipal and then the dom/base/nsFrameLoader.cpp piece, or whatever minimum is needed to get an accurate value back to the indexedDB.

@classilla
Copy link
Owner Author

(and docshell/base/LoadContext.cpp)

@classilla
Copy link
Owner Author

(and dom/ipc/Tab*)

@classilla
Copy link
Owner Author

We have a better solution now thanks to :asuth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant