Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JM backend to be fully ABI-compliant (prerequisite for IonMonkey) #179

Closed
GoogleCodeExporter opened this issue Aug 9, 2015 · 7 comments
Closed

Comments

@GoogleCodeExporter
Copy link
Contributor

I've had enough. Tonight, I did all the work to get JM+TI to have a proper 
arguments area, adjusted all the constants and ran all the initial tests that 
were known to require messing with the stack pointer and they all work. We will 
need this for IonMonkey anyway since it uses the C-stack, so now we will be 
fully ABI compliant for 17.

Stack frame increases from 128 to 160 bytes. Hopefully this doesn't break the 
bank.

Original issue reported on code.google.com by [email protected] on 18 Sep 2012 at 2:16

@GoogleCodeExporter
Copy link
Contributor Author

Original comment by [email protected] on 18 Sep 2012 at 2:16

@GoogleCodeExporter
Copy link
Contributor Author

Original comment by [email protected] on 18 Sep 2012 at 2:17

@GoogleCodeExporter
Copy link
Contributor Author

Even after that, typed arrays still need a larger than normal argument area. 
(The MonoIC and js_Internal_Interpret kludges could be removed.) Dithering over 
increasing it further, or leaving the stack pointer gyration.

Original comment by [email protected] on 18 Sep 2012 at 2:40

@GoogleCodeExporter
Copy link
Contributor Author

Ben, check my math. I'm going through jstypedarray.cpp and I can't find 
anything that has more than 7 arguments (so, counting "this", we should still 
be within the 8). Am I blind?

Incidentally, this post is coming from Firefox 17, so I think most of our 
issues are fixed.

Original comment by [email protected] on 18 Sep 2012 at 2:51

@GoogleCodeExporter
Copy link
Contributor Author

Issue 150 has been merged into this issue.

Original comment by [email protected] on 19 Dec 2012 at 11:15

@GoogleCodeExporter
Copy link
Contributor Author

Original comment by [email protected] on 19 Dec 2012 at 11:15

@GoogleCodeExporter
Copy link
Contributor Author

Now that BaselineCompiler has landed, JM doesn't even get enabled in that 
configuration (when BC+IM+TI), so further work is pointless.

Original comment by [email protected] on 16 Apr 2013 at 1:40

  • Changed state: WontFix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant