Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features.within doesn't terminate in some cases #58

Open
osmuser63783 opened this issue Jun 23, 2024 · 1 comment
Open

Features.within doesn't terminate in some cases #58

osmuser63783 opened this issue Jun 23, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@osmuser63783
Copy link

Try this:

my_water = next(w for w in planet_240617("a[natural=water]") if w.id == 17140040)
islands = planet_240617("a[place=island,islet]").ways
islands_in_water = islands.within(my_water)

The function seems to run forever and never return.

The culprit is an invalid multipolygon relation (only a node as a member) that should arguably never have been returned when I called ("a[natural=water]").
Screenshot 2024-06-23 at 17 46 35

@clarisma clarisma added the bug Something isn't working label Jun 24, 2024
@clarisma
Copy link
Owner

Thanks for catching this!

Invalid multipolygon relations are currently responsible for several issues (#29, #30, clarisma/geodesk#52) -- gol build should remove (or fix) them, we'll address this in clarisma/gol-tool#109, which should be part of the next release of the GOL Tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants