Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a reason for the semicolons before all the method bodies? #6

Open
HiddenJester opened this issue Mar 28, 2014 · 1 comment

Comments

@HiddenJester
Copy link

For example: + (instancetype)iOS7redColor;
{
return [UIColor colorWithRed:1.0f green:0.22f blue:0.22f alpha:1.0f];
}

I'm using https://github.com/boredzo/Warnings-xcconfig in my project as well and there is a warning -Wno-semicolon-before-method-body which is turned on and that promotes up to an error. I get that they are essentially harmless but I don't think they are doing anything either. (I don't use CocoaPods, so it might be important there?)

I pulled the semicolons out on my local copy and everything seems fine. I can send you a Pull request with the change if you would like but I figured I'd ask before just sending it out of the iOS7lightBlueColor 😃

@HiddenJester
Copy link
Author

(sigh) and the instant I hit Post it occurred to me that a closed issue might have addressed this already. So I guess consider this a second vote against the semicolons. Makes copy/paste between .h & .m easier but also triggers an optional warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant