Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement setting for takeback timeout or mutually agreed takeback #52

Closed
geebioso opened this issue Apr 7, 2020 · 6 comments · Fixed by #61
Closed

Implement setting for takeback timeout or mutually agreed takeback #52

geebioso opened this issue Apr 7, 2020 · 6 comments · Fixed by #61
Labels
enhancement New feature or request

Comments

@geebioso
Copy link

geebioso commented Apr 7, 2020

Is your feature request related to a problem? Please describe.
I'm frustrated that if I don't realize I made a mistake within a minute I can't take back a move even when the person I'm playing against agrees that I should be able to take it back.

Describe the solution you'd like
Either
a) a mechanic where if I can take back a move if both my opponent and I agree it can be taken back (e.g, I say @ChessBot takeback and if my opponent agrees he says @ChessBot allow, or something similar) or
b) a setting where you can change the take back time from 0 to anytime before the next player makes a move

Additional context
That's it! Thanks for programming the app. It's great!

@cjsaylor
Copy link
Owner

cjsaylor commented May 27, 2020

@geebioso Agreed, the current implementation of the take back was a simple stop-gap for a more robust solution.

I plan on making the take back request that occur after that initial 1 minute threshold go through a workflow that is similar to the challenge a player workflow. An ephemeral private message will be sent to the other player with a choice to accept or reject the take back request. The complicated part is if I can get the message to only appear to the other player within the thread, or just display it for everyone and reject input from the player requesting the take back.

An additional complication will be if the other player ignores the message and makes a move, I will need to delete/dismiss the option to accept the take back move from prior to the player's move.

I will see if I can get something going for that in the next couple of weeks.

@cjsaylor cjsaylor added the enhancement New feature or request label May 27, 2020
@cjsaylor
Copy link
Owner

The solution to this could also be used in #25

@geebioso
Copy link
Author

Great to hear you're developing on this feature! Thanks for all the work you've put in.

The draw idea is a good add as well!

@cjsaylor
Copy link
Owner

After looking at this, I think the solution outlined above with an interface to request the take back wouldn't replace the timed take back, it would just be the interface to do so after the initial immediate take back time limit has expired.

@cjsaylor
Copy link
Owner

@geebioso This is now live, you can now request a take back after the 1 minute threshold has expired.

@geebioso
Copy link
Author

@cjsaylor That's awesome. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants