Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building Comparison Histograms #46

Open
nicolettehayes opened this issue Jan 24, 2017 · 3 comments
Open

Building Comparison Histograms #46

nicolettehayes opened this issue Jan 24, 2017 · 3 comments
Assignees
Labels

Comments

@nicolettehayes
Copy link
Collaborator

I know it's been a long and winding road for the Building Comparison View, but I wanted to recap from an interaction standpoint the 2 options that I can imagine being positive for implementation. Whichever seems the most doable from a performance standpoint is obviously the priority.

Problem:

Currently, sparklines appear for only the top row in the Comparison chart. When I select another building, the sparklines do not shift to the selected row (and the color highlight also doesn't appear); rather the building highlights off screen on the map.

sparklines

Solution # 1 (keep single row of sparklines in Building Comparison):

When a building is selected within the Building Comparison Chart, the sparklines appear in that row, and disappear from the previously selected row. Simultaneously in the background, the same building becomes selected on the map, but without force-scrolling the user to see it.

Solution # 2 (remove all sparklines in Building Comparison):

Only numbers appear in every row of the Building Comparison Chart. The selected row figures appear in color, but without sparklines. When a different building is selected, those numbers appear in color and the building becomes simultaneously selected on the map. Additionally, I think adding a scroll-to-map functionality could be good.

@emilyhobson emilyhobson changed the title Building Comparison Sparklines Building Comparison Histograms Jan 24, 2017
@emilyhobson emilyhobson added p1 and removed phase 2 labels Jan 24, 2017
@almccon
Copy link
Member

almccon commented Jan 27, 2017

This appears to be equally broken on http://energybenchmarkingdc.org/

almccon added a commit that referenced this issue Jan 28, 2017
@almccon
Copy link
Member

almccon commented Jan 28, 2017

Solution #1 now working when you click on buildings on the map. When you click on buildings in the comparison list, all the histograms disappear unfortunately.
seattle_building_histograms

@sconnelley if you get a chance can you figure out why this line isn't working? It doesn't seem to update the state, instead it sets building to null instead of the value that we want it to set.

this.state.set({building: buildingId});

@emilyhobson emilyhobson assigned almccon and unassigned sconnelley Jan 28, 2017
@almccon
Copy link
Member

almccon commented Jan 28, 2017

To clarify, this is hard to test: If you click on the map it shows the histogram, but it doesn't re-order the list... so most of the time the new histogram is somewhere WAY down the list.

In this gif I filtered the buildings a ton, and ordered them so the two biggest ones were on top. This illustrates how the selected building's histogram shows up in the current sort location, without re-ordering.

Here are the filters I used to get the gif: https://cityenergyproject.github.io/seattle/#seattle/2015?filters[0][field]=energy_star_score&filters[0][min]=80&filters[0][max]=92&filters[1][field]=reported_gross_floor_area&filters[1][min]=369091&layer=reported_gross_floor_area&metrics[]=energy_star_score&metrics[]=reported_gross_floor_area&sort=reported_gross_floor_area&order=desc&lat=47.61087915638172&lng=-122.3248243331909&zoom=14&building=236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants