Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test names and locations #27

Closed
whoabuddy opened this issue Dec 8, 2022 · 0 comments · Fixed by #19
Closed

Update test names and locations #27

whoabuddy opened this issue Dec 8, 2022 · 0 comments · Fixed by #19

Comments

@whoabuddy
Copy link
Contributor

After looking through what we have on feat/migration and feat/migrationplustests, it looks like having the test proposals grouped under the contracts directory will get cluttered very fast.

One idea is to change up the structure so the tests are stored somewhere else, e.g.

contracts <-- only protocol code, no tests
  extensions <-- (ccdNNN)
  external <-- (ccext-)
  proposals <-- (ccip-)
  traits <-- (leave as-is)
tests
  contracts <-- (test proposals)
    test-ccd001-direct-execute-NNN.clar
    test-ccd002-treasury-NNN.clar
    test-ccip012-bootstrap.clar
  extensions <-- (leave as-is)
    ccd001-direct-execute.test.ts

That should scale better, be easier to read, and from there we can start to identify any relevant patterns in the test proposals themselves.

Right now just looking at ccip-test-treasury-006.clar or the newer test-ccd002-treasury-006.clar doesn't tell me much about the test, but we should stick with it for now and look at it alongside #3 for a future refactor.

With fuzzing we could do cool things like setting up the model for what a city looks like it then running the tests on a bunch of different inputs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant