Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aria-roles and labels to components and templates' markup. #65

Open
ChrisBrettCA opened this issue Sep 5, 2018 · 1 comment
Open

Add aria-roles and labels to components and templates' markup. #65

ChrisBrettCA opened this issue Sep 5, 2018 · 1 comment
Labels
refactor Refactor production code

Comments

@ChrisBrettCA
Copy link

No description provided.

@ChrisBrettCA ChrisBrettCA added the refactor Refactor production code label Sep 5, 2018
@manalishi79
Copy link
Contributor

Assigning aria roles at the product or template level is tricky as the components could be used in any context (e.g. dashboard, tool page, content page, splash page etc) We could describe the general high level best practice for aria roles in an application or product but the more granular and prescriptive we get with documentation the more we're building a rod for our own back.

It makes sense to give aria labels for self-contained elements and components e.g. revealables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Refactor production code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manalishi79 @ChrisBrettCA