Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant React code #43

Open
jashmehta3300 opened this issue Oct 25, 2023 · 5 comments
Open

Remove redundant React code #43

jashmehta3300 opened this issue Oct 25, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers react.js

Comments

@jashmehta3300
Copy link
Contributor

Problem Statement

Currently, there is a lot of redundant code present in the React files.

Proposed Solution

It would be great to remove the unnecessary code from one file at a time to keep the code clean. It would also help to format the code correctly and follow the same styling throughout the files (lint).

@jashmehta3300 jashmehta3300 added enhancement New feature or request good first issue Good for newcomers react.js labels Oct 25, 2023
@sricharan200
Copy link

@jashmehta3300, can you assign me this issue? I would like to work on it.

sricharan200 added a commit to sricharan200/martian-bank-demo that referenced this issue Nov 22, 2023
- removed redundant code in react code
@sricharan200
Copy link

sricharan200 commented Nov 22, 2023

@jashmehta3300 , can you please review the above pull request. Thank You.

@sricharan200
Copy link

@jashmehta3300 , can you please review the pull request?

@jashmehta3300
Copy link
Contributor Author

Hi @sricharan200,

Thank you for submitting a PR! I have reviewed it and left a couple of comments. In general, I think there are 2 issues:

  1. You have imported non-existent CSS files which are breaking the frontend code.
  2. You are replacing in-line styles with custom classNames but I don't see those styles being implemented anywhere.

I would recommend that you look at the scripts folder which has a script to run the code locally. That way you will be able to verify if the code is breaking or not, and if styling is consistent before and after changes.
Additionally, we have a demo video to setup MartianBank at: https://video.cisco.com/detail/videos/outshift-by-cisco/video/6334089243112

Thank you.

@dipaksinha1
Copy link

Hi @sricharan200,

Are you still investigating this issue? If not, I would like to request @jashmehta3300 to please assign me this issue.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers react.js
Projects
None yet
Development

No branches or pull requests

3 participants