-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update run_local.sh to create .env files for each microservice #42
Comments
@jashmehta3300 can you please assign me this issue |
Hi @jashmehta3300 , |
Thank you @jashmehta3300 for assigning the issue to me Terminal → asking the user to provide values for the environment variables .env → autocreated like this by extracting variables from .env.example Could you please clarify if this is the right approach or something else is expected. |
Hi @DevanshAshar. Thanks for the suggestion, I think this is the right approach. However, the microservices do not have .env.example files with the variable names currently. It would be great if you could also add those files in the respective folders. Lastly, for the second step (i.e. taking env values for the terminal), I think it would be better if we only ask for DB_URL and keep the other variables optional since they already have default values in the code. |
also added env example files in respective folders co-authored-by: Dhruv <[email protected]> co-authored-by: Tanish <[email protected]> co-authored-by: Vidhita <[email protected]>
Hey @jashmehta3300 have added .env.example files in respective folders and also have added code to auto-create .env with start cmd . |
Problem Statement
Currently the run_loca.sh script (https://github.com/cisco-open/martian-bank-demo/blob/main/scripts/run_local.sh) does not create .env files, and they have to be created manually.
Proposed Solution
Create these files automatically during installation.
The text was updated successfully, but these errors were encountered: