Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add Uni contract deployment logs #50

Open
wants to merge 1 commit into
base: entry-point-v0.6
Choose a base branch
from
Open

chore: Add Uni contract deployment logs #50

wants to merge 1 commit into from

Conversation

czhang-circle
Copy link

@czhang-circle czhang-circle commented Nov 20, 2024 •
edited
Loading

Summary

Add deployment logs for UNI Programmable Wallet contracts. Deployed contracts block explorer links:

PluginManager: https://unichain.blockscout.com/address/0x3169Ad878021B87C9CaA9b5CDA740ff3ca270Ce9
SingleOwnerMSCAFactory: https://unichain.blockscout.com/address/0xa233b124D7b9CFF2D38cB62319e1A3f79144B490

Detail

Changeset

Mandatory section.

Checklist

  • Did you add new tests and confirm all tests pass? (yarn test)
  • Did you update relevant docs? (docs are found in the docs folder)
  • Do your commits follow the Conventional Commits standard?
  • Does your PR title also follow the Conventional Commits standard?
  • If you have a breaking change, is it correctly reflected in your commit message? (e.g. feat!: breaking change)
  • Did you run lint (yarn lint) and fix any issues?
  • Did you run formatter (yarn format:check) and fix any issues (yarn format:write)?

@czhang-circle czhang-circle changed the title chore: add Uni contract deployment logs chore: Add Uni contract deployment logs Nov 20, 2024
huaweigu
huaweigu reviewed Dec 9, 2024
View reviewed changes
Copy link
Contributor

@huaweigu huaweigu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR ready to go?

broadcast/001_DeployPluginManager.s.sol/1301/run-1731513996.json
@@ -18,7 +18,7 @@
},
"additionalContracts": [],
"isFixedGasLimit": false
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huaweigu huaweigu huaweigu left review comments

@ashutosh-ukey ashutosh-ukey Awaiting requested review from ashutosh-ukey

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czhang-circle @huaweigu