Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-story] allow empty blocks #17

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

asharp-circle
Copy link
Contributor

Summary

Our style guide allows for empty blocks. We update our Checkstyle to allow empty blocks, too.

Detail

Prior to this change

This was illegal:

class Clazz {}

With this change

This is legal:

class Clazz {}

This is legal, too:

class Clazz {
}

This is still illegal:

class Class { private String field; }

Testing

This change passes on entity-service & transaction-core.

Documentation

None.


Requested Reviewers: @asharp-circle @creilly12 @istvancircle @rschmitz-circle

Copy link

github-actions bot commented Feb 1, 2024

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@asharp-circle asharp-circle merged commit 0113525 into master Feb 1, 2024
2 checks passed
@asharp-circle asharp-circle deleted the asharp/allow-empty-classes branch February 1, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants