Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring #35

Merged
merged 13 commits into from
Jul 1, 2024
Merged

Refactoring #35

merged 13 commits into from
Jul 1, 2024

Conversation

stroblme
Copy link
Member

@stroblme stroblme commented Jun 11, 2024 •
edited
Loading

This PR cleans up some deprecated files, updates dependencies and adds typing in various methods as mentioned in #21 and #18.
It also removes the matplotlib dependency as mentioned in #32

Melvin Strobl added 9 commits June 11, 2024 14:15
description of parameters
7d559c5 
Signed-off-by: Melvin Strobl <[email protected]>
celanup
93b58cf 
Signed-off-by: Melvin Strobl <[email protected]>
types
7c8ec9c 
Signed-off-by: Melvin Strobl <[email protected]>
switched to debugpy
8f09312 
Signed-off-by: Melvin Strobl <[email protected]>
cleanup
8d91e53 
Signed-off-by: Melvin Strobl <[email protected]>
cleanup
a5b8bc1 
Signed-off-by: Melvin Strobl <[email protected]>
fixed 1d case
36b3625 
Signed-off-by: Melvin Strobl <[email protected]>
more refactoring
9ad2325 
Signed-off-by: Melvin Strobl <[email protected]>
package updates
9640c2e 
Signed-off-by: Melvin Strobl <[email protected]>
@pep8speaks
Copy link

pep8speaks commented Jun 11, 2024 •
edited
Loading

Hello @stroblme! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-06-11 14:31:52 UTC

pep
ddd77dd 
Signed-off-by: Melvin Strobl <[email protected]>
@stroblme stroblme requested a review from cDenius June 11, 2024 13:53
@stroblme stroblme marked this pull request as ready for review June 11, 2024 13:53
Melvin Strobl added 3 commits June 11, 2024 16:29
removed mpl dependency
6f88292 
Signed-off-by: Melvin Strobl <[email protected]>
updates
2978ed3 
Signed-off-by: Melvin Strobl <[email protected]>
updated requirments
349bfc1 
Signed-off-by: Melvin Strobl <[email protected]>
cDenius
cDenius approved these changes Jun 18, 2024
View reviewed changes
Copy link

@cDenius cDenius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaner is always better!

@stroblme stroblme merged commit 44836fc into main Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cDenius cDenius cDenius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stroblme @pep8speaks @cDenius