Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system-style macOS icon #339

Closed
wants to merge 2 commits into from
Closed

Conversation

iLynxcat
Copy link

@iLynxcat iLynxcat commented Aug 30, 2024

Description

This adds a proper system-style icon to fit in with macOS' icon style that's been adopted since Big Sur. In my original issue #322 I offered to include the original Sketch file for this but not sure where/if it fits in the repo or matters whatsoever to the project's maintainers.

Fixes #322

Preview app displaying the highest resolution version of the Cinny app. A white rounded square contains a black circular vector silhouette of a bird.

Type of change

This PR does not include any functionality change to the app and is purely cosmetic. Marking it as "new feature" because it's the best fit.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

This PR does not include any code so I'm checking these off anyway...

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

github-actions bot commented Aug 30, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@iLynxcat
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

ajbura added a commit to cinnyapp/cla that referenced this pull request Aug 30, 2024
@Neved4
Copy link

Neved4 commented Sep 11, 2024

@iLynxcat This is cool! LGTM!

@stefanlight8
Copy link

Can you share .icns file?

@iLynxcat
Copy link
Author

Can you share .icns file?

The .icns file is included in this PR

@iLynxcat
Copy link
Author

Closing since there has been no activity from maintainers since opening — feel free to comment or reopen if this is considered

@iLynxcat iLynxcat closed this Dec 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add consistent macOS app icon
3 participants