btf: export API to create BTF from scratch #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
force-pushed
the
btf-spec-add
branch
3 times, most recently
from
f6e716d
to
575c5e9
Compare
lmb
force-pushed
the
btf-spec-add
branch
3 times, most recently
from
4db9fb3
to
1859ea6
Compare
ti-mo
reviewed
Dec 8, 2022
lmb
force-pushed
the
btf-spec-add
branch
2 times, most recently
from
ddd087a
to
cdaa93d
Compare
ti-mo
approved these changes
Dec 23, 2022
lmb
force-pushed
the
btf-spec-add
branch
3 times, most recently
from
2e537f2
to
9bf579e
Compare
We want to allow creating Spec from scratch, without starting from an ELF. In such cases it's a waste to maintaing a string table. Return an error in code paths that rely on Spec.strings to not be nil. Signed-off-by: Lorenz Bauer <[email protected]>
Export Spec.Add which adds a Type to a Spec. It's then possible to create
BTF on-the-fly like so:
spec := NewSpec()
id, err := spec.Add(...)
handle, err := NewHandle(&spec)
Spec.Add is responsible for allocating type IDs, which makes the BTF
encoder a lot simpler.
Attempting to create a Handle from a Spec that doesn't contain all
types will return an error. This can happen if a Type is modified
after it has been added to a Spec.
Signed-off-by: Lorenz Bauer <[email protected]>
Signed-off-by: Lorenz Bauer <[email protected]>
Replace the bare-bones marshalBTF with marshalTypes, but avoid calling NewHandle to prevent circular dependencies. Signed-off-by: Lorenz Bauer <[email protected]>
lmb
commented
Jan 13, 2023
tpapagian
added a commit
to cilium/tetragon
that referenced
this pull request
Apr 6, 2023
Want to include cilium/ebpf#859 Signed-off-by: Anastasios Papagiannis <[email protected]>
tpapagian
added a commit
to cilium/tetragon
that referenced
this pull request
Apr 7, 2023
Want to include cilium/ebpf#859 go get github.com/cilium/ebpf@master Signed-off-by: Anastasios Papagiannis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Spec.Add, which allows creating BTF on the fly from outside of the btf package.