Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up hooks #447

Open
job13er opened this issue May 11, 2017 · 0 comments
Open

Clean up hooks #447

job13er opened this issue May 11, 2017 · 0 comments
Milestone

Comments

@job13er
Copy link
Contributor

job13er commented May 11, 2017

We should take a pass through all our components and make sure we're following best practices w.r.t. ember-hook.

  • Using hookPrefix and concat helper whenever setting hook on a sub-component or DOM element in our templates.
  • Using camelCase for what we concat onto our own hookPrefix, leaving - for nesting.
  • Using hookQualifiers when appropriate vs. adding text to hook
  • Ensuring that all elements that have a hook are uniquely accessible, either purely through their hook or through a combination of hook and hookQualifiers
@job13er job13er added this to the Next major milestone May 11, 2017
@job13er job13er added LTS 2.0 and removed LTS 2.0 labels May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant