Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getWithDefault is deprecated #186

Open
jgadbois opened this issue Jun 17, 2021 · 0 comments
Open

getWithDefault is deprecated #186

jgadbois opened this issue Jun 17, 2021 · 0 comments

Comments

@jgadbois
Copy link

BUG REPORT

  • [*] I have ensured that the issue isn't already reported
  • [*] I have confirmed that the issue is reproducible with the latest released version
  • [*] I have deleted the FEATURE REQUEST / CODE CHANGE section

Summary

  • Ember 3.26 application is throwing a lot of warnings because getWithDefault has been deprecated.

Expected Behavior

  • ember-prop-types should not throw deprecation warnings

Actual Behavior

  • deprecation warnings in console because of getWtihDefault

Possible Solution

  • getWithDefault should be replaced with get plus an explicit undefined check per the deprecation warning

Steps to Reproduce

  • Use ember-prop-types in an Ember 3.26 application
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant