Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change playback volume via MPRIS/playerctl #871

Open
4 tasks done
oliverlynch opened this issue Dec 21, 2024 · 2 comments
Open
4 tasks done

Cannot change playback volume via MPRIS/playerctl #871

oliverlynch opened this issue Dec 21, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@oliverlynch
Copy link

oliverlynch commented Dec 21, 2024

Preflight Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • I have checked that the correct behavior occurs on Apple Music Web (if applicable).
  • I have verified that my issue is with a supported version and that it is with the desktop app (Support for other areas can be found in our Discord / on the appropriate repo).

How did you download Cider?

itch.io

Operating System

EndevourOS Linux 6.12.4

Commit Hash

75f5a54d6018d10c963cd5d8c7aad2afd529fc73

Build Timestamp

1734728910680

Describe the Bug

In previous versions of cider (2.5.x), it was possible to change the playback volume via MPRIS with playerctl,
e.g. playerctl volume 0.5 would set the volume to 50%, or playerctl volume 0.1+ would increase the volume by 10%.

This no longer seems to work on the current version (2.6.0.2 AppImage).

Other MPRIS features such as play/pause and seek work correctly.
playerctl can correctly read the current volume set in the UI with playerctl volume.

Steps to Reproduce

While Cider is open, run playerctl volume 0.5 or playerctl --player=cider volume 0.5.

Anything else?

Cider's console output triggered by running the playerctl command:

(node:61190) UnhandledPromiseRejectionWarning: Error: Script failed to execute, this normally means an error was thrown. Check the renderer console for the error.
    at node:electron/js2c/renderer_init:2:16600
    at IpcRendererInternal.<anonymous> (node:electron/js2c/renderer_init:2:10905)
    at IpcRendererInternal.emit (node:events:518:28)
    at Object.onMessage (node:electron/js2c/renderer_init:2:8918)
(node:61190) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)

Edit: Error from in-app developer console

Uncaught TypeError: window.CiderApp.RPC.setVolume is not a function
    at <anonymous>:1:21
window.CiderApp.RPC.setVolume(0.10363)

Looks like volume(e) is defined but setVolume(e) is being called instead.

I can provide other logs if required, although the in-app report button/open logs buttons don't seem to work for me...

@oliverlynch oliverlynch added the bug Something isn't working label Dec 21, 2024
@github-project-automation github-project-automation bot moved this to Backlog 📖 in Cider - Bug Reports Dec 21, 2024
@cider-collective
Copy link

Hello @oliverlynch 👋

We really appreciate you taking the time to report this issue, please double check your issue to make sure you are clear and concise in your description. This will help us to help you as quickly as possible.

We'd like to ask you be patient and we will get back to you as soon as we can.

In the meantime, take a look at our FAQs which may answer your question.

Thanks again and we hope you enjoy the app! 😃

@coredev-uk coredev-uk self-assigned this Dec 21, 2024
@coredev-uk
Copy link
Member

Seems like I got the function names wrong. I have made a fix and it will be available in the next client update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog 📖
Development

No branches or pull requests

2 participants