Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

min(teams, key=teams.get) only returns the first key of the minimum value #1

Open
crayfish1037 opened this issue Dec 10, 2017 · 1 comment
Open

min(teams, key=teams.get) only returns the first key of the minimum value #1

crayfish1037 opened this issue Dec 10, 2017 · 1 comment

Comments

@crayfish1037
Copy link

In the _get_optimal_draw scenario 2. If one runner_up has more than one least winner. Use min(teams, key=teams.get) only can return the first one.
I think we can randomly return one of the least winner in the code if the candidate is more than only one.
christarazi added a commit that referenced this issue Dec 10, 2017
@christarazi
Improve _get_optimal_draw: choose random least winner
9ec161f 
Thanks to #1.
@christarazi
Copy link
Owner

Thanks for your suggestion. Is this what you had in mind (in the commit above)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christarazi @crayfish1037