This repository has been archived by the owner on Oct 17, 2018. It is now read-only.
Update to AspNetCore 2.0.0 #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 22, 2017 16:10
Scheme has moved to the RemoteAuthenticationHandler Remove AuthenticationFailed and MessageReceived events. Target netstandard2.0 in the library - with references to net 4.7 libraries. removed SignOut - (its a todo) Add WsFederationPostConfigureOptions (this is almost certainly the wrong way to do this ... I'll fix this soonish). Move ADFS configuration to the JSON configuration file.
…, switch to the IPostConfigureOptions approach. Add UrlEncoder encoder, ISystemClock clock back into the WsFederationAuthenticationHandler constructor (oops) Remove the authenticationScheme parameter from WsFederationAuthenticationOptions
…, the Path will not include the PathBase.
…manager or static variable every time.
Note: you must do .ConfigureLogging(a=>a.SetMinimumLevel(LogLevel.Trace)) in your Program.Main to get these
|
Is there any news regarding this? It would be awesome to be able to start using netstandard2.0 |
|
This pull request is just an experiment at this point. Until official WsFed
libraries go into Nuget from Microsoft, you'd still have to target the full
.NET framework.
…On Mon, Sep 4, 2017 at 5:10 AM Deividas Smailys ***@***.***> wrote:
Is there any news regarding this? It would be awesome to be able to start
using netstandard2.0
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABu24YkMA9mNMUH-HMHGptvwtP5fIgjlks5se9qqgaJpZM4O-Kdg>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Chris,
Dont actually merge this pull request. It does work, but it breaks compatibility with AspNetCore 1.
Would you mind quickly reviewing what I have done and provide some feedback? I am mainly interested to see if you are willing to collaborate on a separate nuget package for WsFed on AspNetCore 2.0.0. I figure your existing library should stay as it is, but I'd like a separate library for use on AspNetCore 2.
Scheme has moved to the RemoteAuthenticationHandler
Remove AuthenticationFailed and MessageReceived events.
Target netstandard2.0 in the library
Move ADFS configuration to the JSON configuration file.