Skip to content
This repository has been archived by the owner on Oct 17, 2018. It is now read-only.

Middleware does not fire when Request.PathBase is not empty #23

Open
MrDustpan opened this issue Nov 29, 2017 · 0 comments
Open

Middleware does not fire when Request.PathBase is not empty #23

MrDustpan opened this issue Nov 29, 2017 · 0 comments

Comments

@MrDustpan
Copy link

MrDustpan commented Nov 29, 2017

Hello,
I'm running into an issue where the middleware doesn't fire on a site that is running under an application in IIS, for example: http://localhost/MySite/MyCallback.

I believe this is due to a difference in the way the CallbackPath is checked between WsFederationAuthenticationHandler and RemoteAuthenticationHandler:

https://github.com/chrisdrobison/aspnetcore-wsfed/blob/master/AspNetCore.Authentication.WsFederation/WsFederationAuthenticationHandler.cs#L37
vs.
https://github.com/aspnet/Security/blob/rel/1.1.3/src/Microsoft.AspNetCore.Authentication/RemoteAuthenticationHandler.cs#L26

As you can see, the base class does not include the Request.PathBase in its logic. Do you think it would make sense to change the WsFederationAuthenticationHandler to match this logic? If so I'd be happy to provide a PR.

@MrDustpan MrDustpan changed the title WsFederationAuthenticationHandler Middleware does not fire when Request.PathBase is not empty Nov 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant