From 926e2ccaa27e4ec9691101deadce414068a3f6aa Mon Sep 17 00:00:00 2001
From: Chris Zen <932644+chris-zen@users.noreply.github.com>
Date: Sun, 30 Jun 2024 09:57:14 +0200
Subject: [PATCH] Do not dispose the client on drop to avoid the CoreMIDI
 server to shutdown in iOS (#53)

---
 src/client.rs | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/src/client.rs b/src/client.rs
index 73f5067b5..ae62687af 100644
--- a/src/client.rs
+++ b/src/client.rs
@@ -7,7 +7,7 @@ use std::cell::RefCell;
 use std::{mem::MaybeUninit, ops::Deref, os::raw::c_void, ptr};
 
 use coremidi_sys::{
-    MIDIClientCreate, MIDIClientCreateWithBlock, MIDIClientDispose, MIDIDestinationCreateWithBlock,
+    MIDIClientCreate, MIDIClientCreateWithBlock, MIDIDestinationCreateWithBlock,
     MIDIDestinationCreateWithProtocol, MIDIEventList, MIDIInputPortCreateWithBlock,
     MIDIInputPortCreateWithProtocol, MIDINotification, MIDINotifyBlock, MIDIOutputPortCreate,
     MIDIPacketList, MIDIReadBlock, MIDIReceiveBlock, MIDISourceCreate,
@@ -330,8 +330,15 @@ impl Deref for Client {
     }
 }
 
-impl Drop for Client {
-    fn drop(&mut self) {
-        unsafe { MIDIClientDispose(self.object.0) };
-    }
-}
+// According to Apple docs:
+//
+// > Don’t explicitly dispose of your client; the system automatically disposes all clients when an app terminates.
+// > However, if you call this method to dispose the last or only client owned by an app, the MIDI server may exit
+// > if there are no other clients remaining in the system. If this occurs, all subsequent calls by your app to
+// > MIDIClientCreate and MIDIClientCreateWithBlock fail.
+//
+// impl Drop for Client {
+//     fn drop(&mut self) {
+//         unsafe { MIDIClientDispose(self.object.0) };
+//     }
+// }