Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for non ASCII character set #4

Open
kishaningithub opened this issue Dec 31, 2018 · 1 comment
Open

Support for non ASCII character set #4

kishaningithub opened this issue Dec 31, 2018 · 1 comment

Comments

@kishaningithub
Copy link
Contributor

kishaningithub commented Dec 31, 2018

It would be great if the symbol set is expanded to include spanish characters

Example symbols - ÇÑñ¿ç

The important point is these symbols belong to UTF-16 character set
and because of this the len function has to be replaced with utf8.RuneCountInString as it deals with runes instead of bytes

@kishaningithub kishaningithub changed the title Support for non ASCII charecter set Support for non ASCII character set Dec 31, 2018
@chr4
Copy link
Owner

chr4 commented Dec 31, 2018

This looks like a valid request! Thanks for the suggestion.

I'd suggest to create a different set for this though, as those characters are hard to type for people with different keyboard layouts, and I don't think it would be wise to include them by default in symbols.
Maybe, we can have something like language-based symbol strings, that can be enabled using a certian flag? (e.g. -l es in your case, but this could also cover other symbols, even arabic or chinese characters).

Pull requests welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants