Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in ZBL potential #328

Open
chrisiacovella opened this issue Dec 3, 2024 · 0 comments
Open

Adding in ZBL potential #328

chrisiacovella opened this issue Dec 3, 2024 · 0 comments
Assignees

Comments

@chrisiacovella
Copy link
Member

Today we (@wiederm @MarshallYan ) discussed some issues that could be faced with free energy calculations related to overlapping atoms when energy is decoupled. As we have discussed in the past, adding in something like the ZBL potential to prevent overlap (even outside of the context of free energy calculations), could be useful, as the NNPs do not necessarily know anything about the energy landscape at really small separations.

this could be done in the post processing, similar to calculating Coulombic energy from partial charges. This just needs to know atomic numbers and the neighbor list information (pairs, d_ij). Even if two atoms are "lifted up" in a free energy calculation, we still can return a the value for the ZBL potential which would prevent overlap (i.e. not impacted by lambda).

I'll work on adding this in as this might be important for stability.

@chrisiacovella chrisiacovella self-assigned this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant