Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to work with Pester 5+ #148

Closed
pauby opened this issue Jun 23, 2020 · 0 comments · Fixed by #163
Closed

Update to work with Pester 5+ #148

pauby opened this issue Jun 23, 2020 · 0 comments · Fixed by #163
Assignees
@JPRuskin
Labels
4 - Done Enhancement NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product.
Milestone
2.x

Comments

@pauby
Copy link
Member

pauby commented Jun 23, 2020

Describe the solution you'd like
After this comment it was clear that cChoco needs to be updated to work with Pester v5+.

This could be related to #147
@pauby pauby added this to the 2.x milestone Jul 16, 2021
@JPRuskin JPRuskin self-assigned this Oct 23, 2021
JPRuskin added a commit to JPRuskin/cChoco that referenced this issue Oct 25, 2021
@JPRuskin
(chocolateyGH-148) Updates Test FileNames to match Best Practice
7ba5c25 
Pester considers all files named *.Tests.ps1 to be test files. This is the default naming convention. This commit adjusts cChoco test filenames to match this.

See: https://pester-docs.netlify.app/docs/usage/file-placement-and-naming#common-convention
JPRuskin added a commit to JPRuskin/cChoco that referenced this issue Oct 25, 2021
@JPRuskin
(chocolateyGH-148) Updates Tests to work in Pester 5.x
d0dab07 
There were some compatibility issues when running the existing tests in Pester 5, and it was noted that it would be good to update them. This commit does so.

Tested using Pester 5.3.1.
@JPRuskin JPRuskin mentioned this issue Oct 25, 2021
Merged
7 tasks
JPRuskin added a commit to JPRuskin/cChoco that referenced this issue Oct 25, 2021
@JPRuskin
(chocolateyGH-148) Updates Tests to work in Pester 5.x
eab5bd0 
There were some compatibility issues when running the existing tests in Pester 5, and it was noted that it would be good to update them. This commit does so.

Tested using Pester 5.3.1.
JPRuskin added a commit to JPRuskin/cChoco that referenced this issue Oct 25, 2021
@JPRuskin
(chocolateyGH-148) Updates Tests to work in Pester 5.x
9701f7f 
There were some compatibility issues when running the existing tests in Pester 5, and it was noted that it would be good to update them. This commit does so.

Tested using Pester 5.3.1.
JPRuskin added a commit to JPRuskin/cChoco that referenced this issue Jul 6, 2023
@JPRuskin
(chocolateyGH-148) Updates Test FileNames to match Best Practice
e03116a 
Pester considers all files named *.Tests.ps1 to be test files. This is the default naming convention. This commit adjusts cChoco test filenames to match this.

See: https://pester-docs.netlify.app/docs/usage/file-placement-and-naming#common-convention
JPRuskin added a commit to JPRuskin/cChoco that referenced this issue Jul 6, 2023
@JPRuskin
(chocolateyGH-148) Updates Tests to work in Pester 5.x
ba889cf 
There were some compatibility issues when running the existing tests in Pester 5, and it was noted that it would be good to update them. This commit does so.

Tested using Pester 5.3.1.
corbob added a commit that referenced this issue Jul 7, 2023
@corbob
Merge pull request #163 from JPRuskin/148-Pester5
69e2587 
(GH-148) Updates Tests to be compatible with Pester 5
@corbob corbob added 4 - Done NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product. and removed 3 - Review labels Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JPRuskin JPRuskin

Labels
4 - Done Enhancement NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product.
Projects
None yet
Milestone
2.x
Development

Successfully merging a pull request may close this issue.

(GH-148) Updates Tests to be compatible with Pester 5 JPRuskin/cChoco
3 participants
@JPRuskin @pauby @corbob