Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics to usage of cache in handlers #36

Open
3 tasks
jamestelfer opened this issue May 13, 2024 · 0 comments
Open
3 tasks

Add metrics to usage of cache in handlers #36

jamestelfer opened this issue May 13, 2024 · 0 comments
Milestone

Comments

@jamestelfer
Copy link
Collaborator

jamestelfer commented May 13, 2024

The handlers use a cache with the PipelineID as a key that will return the same token on repeated requests for a given pipeline.

We need to change our telemetry such that:

  • the current span has a hit/miss indicator for cache usage
  • there is a special case around repository URL handling that causes a cache miss: annotate this on the span also
  • add cache metrics so we can track hit rate over time. Pipeline name or ID would be useful as attributes for this metric.
@jamestelfer jamestelfer added this to the chinmina v1 milestone May 13, 2024
@jamestelfer jamestelfer moved this to Backlog in chinmina May 13, 2024
@jamestelfer jamestelfer moved this from Backlog to Ready in chinmina May 13, 2024
@jamestelfer jamestelfer changed the title Add telemetry to cache usage Add metrics to usage of cache in handlers May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant