fix(proxyReqWs): catch socket errors on 0.19.2 #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1642 on the 0.19.x branch.
Description
The PR copies proposed changes form this comment
Motivation and Context
The issue has already been fixed and closed on newer versions. Unfortunately we are using an older version of angular and one of the core angular libraries use the 0.19.1 version of this package. We've created a private fork with this fix, but figured, someone could use this as well.
How has this been tested?
We've created a fork for a private npm feed. It works well for us.
Types of changes
Checklist:
PS
This is my first ever contribution to a public repo. I've tried to follow every policy, as best as I could. Sorry, if I missed something.