Update options.changeOrigin description in docs

[asvae]

changeOrigin has nothing to do with origin header which is confusing and harmful when working with CORS. As CORS middleware sometimes makes decisions depending on origin header.

changeOrigin option handles solely host header.

[coveralls]

Coverage remained the same at 96.97% when pulling 169338a on asvae:patch-1 into 8689cb4 on chimurai:master.

[chimurai]

Thanks for the PR @asvae.

Indeed it can be confusing.

This piece of documentation it taken directly from the http-proxy README.

Can you create a PR in the http-proxy project?
I'll merge it when it is accepted/merged there.

[asvae]

@chimurai Sure. Here it is.
Waiting for reply.

[chimurai]

Great thanks!

[nicojs]

Shouldn't the option be renamed to changeHost? We actually need the use case of changing the origin header. How to contribute if the name is already taken? 😕

[johnhunter]

Any news on this @chimurai ? This is particularly confusing as consuming projects assume it does change the Origin header, e.g. vitejs/vite#16557 (comment)

@nicojs raises a good point but renaming it would be a breaking change and there may be projects that depend on the setting.

I vote for merging this doc change so it is at least possible to understand the behaviour once you read the docs.

[johnhunter]

Ah, http-proxy docs need updated first. I'll check that.