[BREAKING] option to use the card's set symbol rather than default symbol #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also now storing `file_path` on template instance
ndepaola
force-pushed
the
expansion-symbol-picker
branch
from
b93731d to
f96238a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BREAKING] here refers to the fact that this PR will not work with current templates - they will need to be updated with the required layer structure. I'll hold off on merging this until I update all templates for compatibility.
You may have mixed results with this feature as applying a 6 px outer stroke doesn't look visually correct for all symbols.
Having some issues with a couple of SVGs from Scryfall (e.g.
STXandM21), will report back if I get to the bottom of this. If you have any suggestions for how to solve this without introducing any python dependencies, please send them my way!Example of automatically selected expansion symbol: