Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some changes pushed to main #689

Closed
jaraco opened this issue Apr 18, 2024 · 9 comments
Closed

Some changes pushed to main #689

jaraco opened this issue Apr 18, 2024 · 9 comments
Labels
bug Something is broken triage

Comments

@jaraco
Copy link
Member

jaraco commented Apr 18, 2024

@webknjaz FYI - as part of my work in coherent-oss/roadmap#8, I pushed some changes directly to cheroot main. I don't want to disrupt the current RC release, so I'm going to disable force-pushes on main and back out those changes.

@jaraco jaraco added bug Something is broken triage labels Apr 18, 2024
@jaraco
Copy link
Member Author

jaraco commented Apr 18, 2024

I've done that by temporarily allowing force-pushes, pushing HEAD~2 to main, and then once again disabling force pushes to main. Now the proposed changes are in feature/pep-621, which I'll put through a PR.

@jaraco jaraco closed this as completed Apr 18, 2024
@webknjaz
Copy link
Member

Okay, it looks like I'll be releasing 10.0.1 from a separate branch so this shouldn't be in the way. Later, I wanted to debug more TLS-related tracebacks with some things only present locally currently.

@webknjaz
Copy link
Member

Though, I do prefer having setup.cfg separate from pyproject.toml (as well as other configs) as it's easier to figure out where things are and sync across projects with less conflicts.

OTOH, with things like the dependency groups, it might make sense to host the metadata in pyproject.toml. I'm a little conflicted here.

@webknjaz
Copy link
Member

I've done that by temporarily allowing force-pushes, pushing HEAD~2 to main

Are you sure you pushed the right commit back? I'm pretty the CI was green on the head of main before. Let me check if the last commit locally is the same...

@webknjaz
Copy link
Member

Alrigh.. It looks the same:

* 3591a1ce - (origin/main, main) 💅 Keep empty line separators next to YAML marks (2 days ago) <Sviatoslav Sydorenko>

This likely means that something isn't pinned fully for the docs envs in the CI.. I'll have to figure it out then.

@webknjaz
Copy link
Member

The most obvious difference is

- .pkg: packaging==24.0,pip==24.0,setuptools==69.1.0,setuptools-scm==8.0.4,tomli==2.0.1,typing_extensions==4.11.0,wheel==0.42.0
+ .pkg: packaging==24.0,pip==24.0,setuptools==69.5.1,setuptools-scm==8.0.4,tomli==2.0.1,typing_extensions==4.11.0,wheel==0.43.0
32

@webknjaz
Copy link
Member

Though

WARNING: cannot cache unpickable configuration value: 'spelling_filters' (because it contains a function, class, or module object)

suggests it's a runtime thing, it shouldn't be related to packaging...

@jaraco
Copy link
Member Author

jaraco commented Apr 19, 2024

I think it was Setuptools 69.3 that changed the names of sdists with dashes in the name.

@webknjaz
Copy link
Member

@jaraco yes, but I don't think it's the cause. The Sphinx problem specifically does not seem to be caused by that, at least. I think that one might be related to Sphinx's caching but I don't understand why it didn't manifest itself earlier. Anyway, I'll try fixing it later since it's past midnight already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken triage
Projects
None yet
Development

No branches or pull requests

2 participants