Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question related to #91 #202

Closed
mar10 opened this issue May 18, 2019 · 7 comments
Closed

Question related to #91 #202

mar10 opened this issue May 18, 2019 · 7 comments
Labels
question StackOverflow

Comments

@mar10
Copy link
Contributor

mar10 commented May 18, 2019

Hi,

This is a question related to #91. I did not want to mess up the discussion there:

I don't know, if this helps, but I experience a situation where I run my WebDAV server on top of Cheroot.
Benchmarks show that it is very slow compared to using Gevent.
This only occurs when uploading a lot of files using File Explorer. macOS Finder behaves way better, so it is also related to the request sequence used (see mar10/wsgidav#149).
I am not sure what exactly is happening there, but increasing the thread count helps.
When it's slow, the console output looks like timeouts every few seconds, so I figured it may be addressed by this issue
I tried with pip install git+https://github.com/cherrypy/cheroot.git@feature/91-non-blocking-sockets and setting back to 10 threads, which I think is the default. but the performance did not increase compared to Gevent.
I you think this is related to issue 91, I can send more debug info or run test versions here.
Otherwise, simply close this...

@webknjaz
Copy link
Member

Well, it's still thread-based. Gevent is asynchronous which helps it to utilize the network better.

@mar10 try testing #199 which is a rewrite of #176/#117

@webknjaz
Copy link
Member

So try pip install git+https://github.com/the-allanc/cheroot.git@request-based-workers

@mar10
Copy link
Contributor Author

mar10 commented May 20, 2019

This is a major improvement compared to the previous runs (see this comment 3. and 4.).
Copying 300 files à 1MB, using cheroot with 10 threads:
image
The first 200 files get copied pretty fast, so cheroot become usable with a low thread count for me now!

Same with 100 threads does not show much of a difference:
image

Still not quite as fast as gevent, but anyways:
image

Note that the raw PUT throughput seems not to be the problem. It's more the handling of different involved WebDAV requests I assume.

@stale
Copy link

stale bot commented Jul 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale This thing has been ignored for too long label Jul 19, 2019
@webknjaz webknjaz added question StackOverflow and removed stale This thing has been ignored for too long labels Jul 19, 2019
@stale
Copy link

stale bot commented Sep 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale This thing has been ignored for too long label Sep 18, 2019
@webknjaz webknjaz removed the stale This thing has been ignored for too long label Sep 18, 2019
@webknjaz
Copy link
Member

@mar10 is this still relevant?

@mar10
Copy link
Contributor Author

mar10 commented Oct 12, 2019

Did only a smoke test, but it seems to be fixed. Thanks!

@mar10 mar10 closed this as completed Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question StackOverflow
Projects
None yet
Development

No branches or pull requests

2 participants