New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why only consider negative features in backward push? #2

Open

wzfhaha opened this issue Feb 24, 2021 · 1 comment

wzfhaha commented Feb 24, 2021 •

edited

Loading

For the BackwardPush function in base.h, the code seems only perform backward push only for negative features.

GBP/precompute/base.h

Line 154 in f811fc2

double old = negativeFeature[w][ik];

Author

wzfhaha commented Feb 24, 2021

Another question, the code actually adopts BiPPR as the propagation rule, which is not consistent with the paper.

Line 24 in f811fc2

features = BiP.ppr(datastr,alpha,rmax,rrz)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment