Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign Mask #24

Merged
merged 22 commits into from
Jun 1, 2024
Merged

Redesign Mask #24

merged 22 commits into from
Jun 1, 2024

Conversation

chengchingwen
Copy link
Owner

The goal of the redesign is to support:

  1. better type hierarchy for dispatch. This helps the function that can only accept sequence masks to work with combined masks.
    https://github.com/chengchingwen/Transformers.jl/blob/91a3fe00bad5bb9ebff35b61356c3d52ad3efba3/src/loss.jl#L29-L31
  2. make it easier to use the mask in GPU kernel (for flash-attention-like gpu kernel #23)

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2024

Codecov Report

Attention: Patch coverage is 77.10843% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 74.52%. Comparing base (40922f8) to head (3af9063).
Report is 2 commits behind head on master.

Current head 3af9063 differs from pull request most recent head 297cc23

Please upload reports for the commit 297cc23 to get more accurate results.

Files Patch % Lines
src/mask/indexer.jl 71.79% 11 Missing ⚠️
src/mask/mask.jl 66.66% 7 Missing ⚠️
src/mask/broadcast.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   74.51%   74.52%   +0.01%     
==========================================
  Files          30       30              
  Lines        2052     2057       +5     
==========================================
+ Hits         1529     1533       +4     
- Misses        523      524       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chengchingwen chengchingwen marked this pull request as ready for review May 31, 2024 15:17
@chengchingwen chengchingwen merged commit 297cc23 into master Jun 1, 2024
7 of 8 checks passed
@chengchingwen chengchingwen deleted the mask branch June 1, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants