Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHEF-14475- Updated plan.sh file to work with different hab packages #3282

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nikhil2611
Copy link
Contributor

Description

Updated the plan.sh file to bundle different components hab packages
Fixing the gems pull from github like ruby-shadow
Creating gem_version_menifest.json writing gems versions in that

Related Issue

https://progresssoftware.atlassian.net/browse/CHEF-14475

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Copy link

netlify bot commented Oct 9, 2024

👷 Deploy Preview for chef-workstation processing.

Name Link
🔨 Latest commit 30173ae
🔍 Latest deploy log https://app.netlify.com/sites/chef-workstation/deploys/67092690a006350008fdf33e

habitat/plan.sh Outdated
@@ -1,5 +1,5 @@
pkg_name=chef-workstation
pkg_origin=chef
pkg_origin=ngupta26

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this need to change based on where the package is released after a ci pipeline is in place?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we will be updating all origin name from ngupta26/ to chef/ origin once the pipeline are in place.

habitat/plan.sh Outdated
@@ -32,6 +29,9 @@ pkg_deps=(
core/libarchive
core/coreutils
core/git
ngupta26/cookstyle
ngupta26/berkshelf
ngupta26/chef-cli

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly for the origins of these packages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah these too we will be pulling from chef/ origin like chef/cookstyle, chef/chef-cli etc

Copy link

sonarcloud bot commented Oct 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants