Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collectiongain fails to recognize albums for m4a (aac) files #27

Open
jtbr opened this issue Jul 24, 2020 · 2 comments
Open

collectiongain fails to recognize albums for m4a (aac) files #27

jtbr opened this issue Jul 24, 2020 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@jtbr
Copy link

jtbr commented Jul 24, 2020

When I run collectiongain on an album containing (at least some) AAC files, the individual tracks are always marked as single tracks rather than as an album:

~/Music/Fiona Apple/Tidal $ collectiongain --regain -d .
Collecting files ...
  [1] 08 The Child Is Gone.m4a |<single track>
  [2] 04 Criminal.m4a |<single track>
  [3] 09 Pale September.m4a |<single track>
  [4] 03 Shadowboxer.m4a |<single track>
  [5] 05 Slow Like Honey.m4a |<single track>
  [6] 02 Sullen Girl.m4a |<single track>
  [7] 10 Carrion.m4a |<single track>
  [8] 06 The First Taste.m4a |<single track>
  [9] 01 Sleep To Dream.m4a |<single track>
  [10] 07 Never Is A Promise.m4a |<single track>

Even though both the artist, albumartist, and album are set to be the same for all these files. At first, albumartist was not set, and I thought that could be the problem, but I get the same result when it is set to equal artist. These files do not have MusicMatch tags.

@jtbr
Copy link
Author

jtbr commented Jul 27, 2020

I noticed PR #25 which seemed like it might solve the issue. Indeed, after manually patching my install, collectiongain seems to be working correctly for these mp4 files.

@chaudum chaudum added the enhancement New feature or request label Sep 3, 2020
@chaudum
Copy link
Owner

chaudum commented Sep 3, 2020

I'm happy to hear that #25 works with your files. m4a support should go into the next release.

@chaudum chaudum added this to the Release 3.x milestone Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants