Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider bumping version number to > 1.3.4 #16

Open
smcv opened this issue May 14, 2020 · 1 comment
Open

Consider bumping version number to > 1.3.4 #16

smcv opened this issue May 14, 2020 · 1 comment
Labels
discuss This issue or pull request needs further discussion

Comments

@smcv
Copy link
Contributor

smcv commented May 14, 2020

I used to maintain the old rgain package in Debian, and I'm now looking at packaging rgain3 as a replacement. rgain3 1.0.0 is a continuation/fork of rgain 1.3.4, so it seems potentially confusing that the version number has gone down.

In particular, because the git repository already contains tags for versions like 1.0.1 and 1.2, it will not be possible to reuse those version numbers, which might lead to some odd versioning in future.

It might be less confusing all round if this fork started from version 2 or 3 (or 1.4 or something) so that the version numbers are monotonically increasing.

@chaudum
Copy link
Owner

chaudum commented May 19, 2020

I used to maintain the old rgain package in Debian, and I'm now looking at packaging rgain3 as a replacement. rgain3 1.0.0 is a continuation/fork of rgain 1.3.4, so it seems potentially confusing that the version number has gone down.

I've thought about starting with version 3 when I did the first release of rgain3 (see #6 )

In particular, because the git repository already contains tags for versions like 1.0.1 and 1.2, it will not be possible to reuse those version numbers, which might lead to some odd versioning in future.

That is a good argument!

It might be less confusing all round if this fork started from version 2 or 3 (or 1.4 or something) so that the version numbers are monotonically increasing.

I would rather use version 3 than 2, and I am happy to do so with the next release.

@chaudum chaudum added the discuss This issue or pull request needs further discussion label Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss This issue or pull request needs further discussion
Projects
None yet
Development

No branches or pull requests

2 participants