enhance: no erase when flashing by default, close #33

ch32-rs · Nov 4, 2023 · 33fa2a3 · 33fa2a3
1 parent 5d569d0
commit 33fa2a3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- No erase by default when flashing
+
 ## [0.0.7] - 2023-11-04
 
 ### Added

diff --git a/src/main.rs b/src/main.rs
@@ -70,9 +70,9 @@ enum Commands {
         /// Address in u32
         #[arg(short, long, value_parser = parse_number)]
         address: Option<u32>,
-        /// Do not erase flash before flashing
-        #[arg(long, short = 'E', default_value = "false")]
-        no_erase: bool,
+        /// Erase flash before flashing
+        #[arg(long, short, default_value = "false")]
+        erase: bool,
         /// Do not reset and run after flashing
         #[arg(long, short = 'R', default_value = "false")]
         no_run: bool,
@@ -303,7 +303,7 @@ fn main() -> Result<()> {
                 }
                 Flash {
                     address,
-                    no_erase,
+                    erase,
                     no_run,
                     path,
                 } => {
@@ -319,7 +319,7 @@ fn main() -> Result<()> {
                         start_address
                     );
 
-                    if !no_erase {
+                    if erase {
                         log::info!("Erase Flash");
                         probe.erase_flash()?;
                     }