From a8edd02d819fc381aae14f923e3fc22f35687228 Mon Sep 17 00:00:00 2001
From: Chris Griego <cgriego@gmail.com>
Date: Thu, 26 Dec 2024 14:50:34 -0800
Subject: [PATCH] Support Ruby 3.4 (#208)

---
 .github/workflows/test.yaml               | 25 +++++++++++++++++++++++
 CHANGELOG.md                              |  4 ++++
 active_attr.gemspec                       |  2 +-
 spec/functional/active_attr/model_spec.rb |  3 ++-
 4 files changed, 32 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
index d1c19c3..49da536 100644
--- a/.github/workflows/test.yaml
+++ b/.github/workflows/test.yaml
@@ -26,6 +26,7 @@ jobs:
         - "3.1"
         - "3.2"
         - "3.3"
+        - "3.4"
         - truffleruby-head
         gemfile:
         - gemfiles/rails_3_0.gemfile
@@ -235,6 +236,30 @@ jobs:
           gemfile: gemfiles/rails_5_1.gemfile
         - ruby: "3.3"
           gemfile: gemfiles/rails_5_2.gemfile
+        - ruby: "3.4"
+          gemfile: gemfiles/rails_3_0.gemfile
+        - ruby: "3.4"
+          gemfile: gemfiles/rails_3_1.gemfile
+        - ruby: "3.4"
+          gemfile: gemfiles/rails_3_2.gemfile
+        - ruby: "3.4"
+          gemfile: gemfiles/rails_4_0.gemfile
+        - ruby: "3.4"
+          gemfile: gemfiles/rails_4_1.gemfile
+        - ruby: "3.4"
+          gemfile: gemfiles/rails_4_2.gemfile
+        - ruby: "3.4"
+          gemfile: gemfiles/rails_5_0.gemfile
+        - ruby: "3.4"
+          gemfile: gemfiles/rails_5_1.gemfile
+        - ruby: "3.4"
+          gemfile: gemfiles/rails_5_2.gemfile
+        - ruby: "3.4"
+          gemfile: gemfiles/rails_6_0.gemfile
+        - ruby: "3.4"
+          gemfile: gemfiles/rails_6_1.gemfile
+        - ruby: "3.4"
+          gemfile: gemfiles/rails_7_0.gemfile
         - ruby: truffleruby-head
           gemfile: gemfiles/rails_3_0.gemfile
         - ruby: truffleruby-head
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4b75b78..1f6904c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,7 @@
+# ActiveAttr (Unreleased)
+
+* ActiveAttr now supports Ruby 3.4
+
 # ActiveAttr 0.17.1 (November 12, 2024)
 
 * ActiveAttr now supports Rails 8.0
diff --git a/active_attr.gemspec b/active_attr.gemspec
index 1024f23..3e744de 100644
--- a/active_attr.gemspec
+++ b/active_attr.gemspec
@@ -29,7 +29,7 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "bundler"
   gem.add_development_dependency "factory_bot",  "< 7.0"
   gem.add_development_dependency "minitest"
-  gem.add_development_dependency "rake",         ">= 0.9.0", "< 13.1"
+  gem.add_development_dependency "rake",         ">= 0.9.0", "< 13.3"
   gem.add_development_dependency "rspec",        "~> 3.0"
   gem.add_development_dependency "tzinfo"
 end
diff --git a/spec/functional/active_attr/model_spec.rb b/spec/functional/active_attr/model_spec.rb
index 6da2992..592be04 100644
--- a/spec/functional/active_attr/model_spec.rb
+++ b/spec/functional/active_attr/model_spec.rb
@@ -1,3 +1,4 @@
+ # frozen_string_literal: true
 require "spec_helper"
 require "active_attr/model"
 require "active_model/mass_assignment_security"
@@ -141,7 +142,7 @@ def self.name
           private
 
           def remove_whitespaces
-            name.strip!
+            self.name = name.strip
           end
 
           def set_status