Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to download asset objects #23

Open
enriquegh opened this issue Apr 16, 2019 · 1 comment · May be fixed by #24
Open

Ability to download asset objects #23

enriquegh opened this issue Apr 16, 2019 · 1 comment · May be fixed by #24

Comments

@enriquegh
Copy link
Contributor

Hello! Wanted to run something by the maintainers before doing any work on this.
Currently, there are the get_job_assets and get_job_asset_url methods that get a list of available assets and get you the correct asset URL respectively.
There is, however, no way to actually download the file (screenshot, log file, har file, etc) to your machine.

This is something that could be done pretty easily. It would involve either refactoring the request method or creating a separate request method for this since we would get the content itself and save it.

Is this something that would be welcome as a PR?
@cgoldberg
Copy link
Owner

go for it

@enriquegh enriquegh linked a pull request Apr 20, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Download assets method enriquegh/sauceclient
2 participants
@cgoldberg @enriquegh