Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouped / sub topic body alignment, progress bars #14

Closed
swashbuck opened this issue Dec 13, 2023 · 1 comment · Fixed by #17
Closed

Grouped / sub topic body alignment, progress bars #14

swashbuck opened this issue Dec 13, 2023 · 1 comment · Fixed by #17
Assignees
Labels
bug Something isn't working released

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Dec 13, 2023

Subject of the issue

The menu item body of grouped sub topics isn't aligned with the sub topic's title. This currently uses text-indent. This causes problems with multi-line titles, though, so we should probably switch to padding-left instead?

Also, the progress bars are inconsistent and squished.

TOC alignment

Steps to reproduce

Set up grouping in TOC in course.json. This example can use the Vanilla build.

  "_toc": {
    "_grouping": {
      "_classes": "",
      "title": "",
      "_items": [
        {
          "title": "",
          "_ariaLevel": 1,
          "_classes": "",
          "_contentObjects": [
            "co-05",
            "co-10"
          ],
          "_grouping": {
            "_classes": "",
            "title": "",
            "_items": [
              {
                "title": "Subgroup lorem ipsum delorum long group name",
                "_ariaLevel": 1,
                "_classes": "",
                "_contentObjects": [
                  "co-15"
                ]
              }
            ]
          }
        }
      ]
    }
  }
@swashbuck swashbuck added the bug Something isn't working label Dec 13, 2023
@swashbuck swashbuck changed the title Grouped / sub topic body alignment Grouped / sub topic body alignment, progress bars Dec 13, 2023
@swashbuck swashbuck self-assigned this Mar 7, 2024
github-actions bot pushed a commit that referenced this issue Mar 22, 2024
## [1.1.2](v1.1.1...v1.1.2) (2024-03-22)

### Fix

* Fix grouped / sub topic body alignment, progress bar width (fixes #14) ([66b19f8](66b19f8)), closes [#14](#14)
Copy link

🎉 This issue has been resolved in version 1.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant