Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State.isTrickleEnabled getter/setter confusion #41

Open
danielghost opened this issue Jun 30, 2022 · 0 comments
Open

State.isTrickleEnabled getter/setter confusion #41

danielghost opened this issue Jun 30, 2022 · 0 comments

Comments

@danielghost
Copy link
Contributor

Setting State.isTrickleEnabled doesn't affect the actual value, as this will always be determined by the getter condition. If the intention is to always see whether trickle is enabled and not whether it should be enabled, it may make sense to change the methods accordingly.

This can currently cause rendering issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielghost