Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text cannot be selected #33

Closed
chris-steele opened this issue Jun 17, 2022 · 4 comments
Closed

Text cannot be selected #33

chris-steele opened this issue Jun 17, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@chris-steele
Copy link
Contributor

Within the page content (excluding notify popups) the user is unable to perform text operations such as select when scrollsnap is active.

@danielghost
Copy link
Contributor

danielghost commented Jun 17, 2022

This will be due to the Hammer.js library used to handle swipe gestures. If gestures are required, delete Hammer.defaults.cssProps.userSelect; could be added to maintain text selection, but the UX may suffer - see http://hammerjs.github.io/tips/.

@swashbuck
Copy link

swashbuck commented Jun 29, 2022

I’ve set userSelect to "auto" in the Hammer.js library. We will now do some further testing in our project.

The main issue I've found on desktop is that, in some cases, all text in the current block will be selected. This only happens on desktop when clicking with your mouse and then swiping up or down (similar to touching the screen and swiping). If you simply swipe up or down with a touchpad, no text is selected. Same for clicking the "next" button in the ScrollSnap bar... no issues.

On iPad (tested iPad Pro 5th gen), no text is selected when touching / swiping. An extended touch / press is required to begin selecting text. So, I did not see this problem there.

@oliverfoster oliverfoster added the bug Something isn't working label Jun 30, 2022
@danielghost
Copy link
Contributor

Do we wish to change the default settings where text is not selectable?

@danielghost
Copy link
Contributor

Discussed and agreed that the default setting will be to leave as is (text not selectable) to ensure there are no potential side effects with gestures. If required, this can be changed for specific projects as detailed in earlier comments.

@danielghost danielghost closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants