Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAT: Assess for supported plugins inclusion #20

Open
swashbuck opened this issue Nov 14, 2024 · 2 comments · May be fixed by #21
Open

AAT: Assess for supported plugins inclusion #20

swashbuck opened this issue Nov 14, 2024 · 2 comments · May be fixed by #21
Assignees
Labels
enhancement New feature or request

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Nov 14, 2024

Subject of the enhancement

Assess plugin for AAT compatibility and inclusion on the supported plugins list.

We have had several requests to add this plugin to the AAT supported plugins list. We also almost always use Scroll Prompt in client themes. The plugin provides a navigational aid which is helpful on smaller screens.

@swashbuck swashbuck added the enhancement New feature or request label Nov 14, 2024
@swashbuck swashbuck changed the title AAT: Assess for AAT compatibility AAT: Assess for AAT supported plugins inclusion Nov 14, 2024
@swashbuck swashbuck changed the title AAT: Assess for AAT supported plugins inclusion AAT: Assess for supported plugins inclusion Nov 14, 2024
@swashbuck swashbuck self-assigned this Dec 5, 2024
@swashbuck swashbuck linked a pull request Dec 5, 2024 that will close this issue
@kirsty-hames
Copy link
Contributor

kirsty-hames commented Dec 17, 2024

Assess plugin for AAT compatibility and inclusion on the supported plugins list.

We have had several requests to add this plugin to the AAT supported plugins list. We also almost always use Scroll Prompt in client themes. The plugin provides a navigational aid which is helpful on smaller screens.

I think this wasn't initially included in the AAT supported plugins list due to the development of the Hero component which includes a similar feature. And would want to avoid maintaining multiple plugins with similar functionality. Having said that, with the Hero we're limited to page content only (as Adapt doesn't support components within the menu). Does your current project use case of Scroll Prompt include enabling this for menus?

  • Likely, the schemas would need to be updated

If we want to support v1 AAT then yes.

  • Accessibility compliance?

Yes and this would be a quick one to test and implement (see comment).

As _textAlignment is configurable for all model display text (title, body and instruction) then I think the button position should be configurable for consistency.
The configurable button icon is less pressing I'd say and could be implemented later if desire to. Currently we can easily override the icon in a custom theme although the configuration would be a nice to have.

@swashbuck
Copy link
Contributor Author

Having said that, with the Hero we're limited to page content only (as Adapt doesn't support components within the menu). Does your current project use case of Scroll Prompt include enabling this for menus?

@kirsty-hames I just used the Hero plugin last week and didn't realize that it has "scroll prompt" functionality included. I do not have a use case for including the button on the menu. I would be in favor of shifting AAT focus to the Hero plugin since it is a more robust solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants