Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement _returnToPreviousLocation selector #55

Closed
guywillis opened this issue Mar 1, 2024 · 3 comments · Fixed by #56
Closed

Reimplement _returnToPreviousLocation selector #55

guywillis opened this issue Mar 1, 2024 · 3 comments · Fixed by #56
Assignees
@swashbuck
Labels
bug Something isn't working released

Comments

@guywillis
Copy link
Contributor

guywillis commented Mar 1, 2024 •
edited
Loading

Subject of the issue

We currently use the _returnToPreviousLocation option in projects to return users to their previous position in the course if they navigate away to another page e.g. a help page.

We do supplement this button with the navigation back button but find it provides a better user flow to the page to have a button at the end that returns them to their previous location.

Tagging @swashbuck @oliverfoster for visibility

Your environment

  • Master FW & AAT
@guywillis guywillis added the bug Something isn't working label Mar 1, 2024
@guywillis guywillis changed the title Reimplement returnToPrevious selector Reimplement _returnToPreviousLocation selector Mar 1, 2024
@swashbuck swashbuck self-assigned this Mar 4, 2024
@swashbuck
Copy link
Contributor

@guywillis Sorry about that. I should be able to restore some of this work from the issue/41 branch from before the team decided to axe the option.

@swashbuck swashbuck mentioned this issue Mar 4, 2024
Merged
@swashbuck
Copy link
Contributor

@guywillis PR #56 is ready for review.

oliverfoster added a commit that referenced this issue Mar 6, 2024
@oliverfoster
Fix: Restore _returnToPreviousLocation option (fix #55)
62bc380
github-actions bot pushed a commit that referenced this issue Mar 6, 2024
@semantic-release-bot
Chore(release): 3.0.1 [skip ci]
a6b23f6 
## [3.0.1](v3.0.0...v3.0.1) (2024-03-06)

### Fix

* Restore _returnToPreviousLocation option (fix #55) ([62bc380](62bc380)), closes [#55](#55)
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

🎉 This issue has been resolved in version 3.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Restore _returnToPreviousLocation option (fix #55) cgkineo/adapt-pageNav
2 participants
@swashbuck @guywillis