-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close not unlocking on page complete #51
Comments
It sounds very much like something else is happening which is causing an error to occur in the processing of the buttons. It's the same bit of code which manages updating both buttons, at the same time. Line 32 in 0eb5467
Line 91 in 0eb5467
Any console logs? |
As the close button doesn't have an Line 80 in 0eb5467
Which prevents the button from rerendering on page:_isComplete change. I suggest just removing the line. |
Bug is probably fixed in upcoming pr #49 |
I'm still seeing this behaviour in a course I'm building in the AAT, using v2.4.0. EDIT - interestingly, as a means of trying to get around this issue (needing to leave the page and re-enter in order to get the close button to activate), i added trickle to the last block of content on the page before the page nav. so you complete that block and then the page nav is revealed. when i do this, the close button does become active on page complete, without needing to leave and re-enter. |
@StuartNicholls any progress? |
@oliverfoster sorry, not got to this yet |
v2.4.0 was the last version before the aforementioned pr, I would expect it to have the bug. |
Subject of the issue/enhancement/features
Describe your issue here.
The close button is not unlocking when the page is complete although the next button locking is working fine.
Your environment
AAT version: 0.10.5 | Framework version: 5.25.0
Chrome - latest version
Steps to reproduce
Tell us how to reproduce this issue.
Required page with PageNav at the bottom of the page (page is not added to plp). Close is set to unlock once page is complete. Click through components close button doesn't unlock unless you go to menu or previous page and return to page with close button.
Expected behaviour
Tell us what should happen
Close button should unlock after page complete as per next button.
Actual behaviour
Tell us what happens instead
Close button does not unlock even after the page is complete.
Screenshots (if you can)
The text was updated successfully, but these errors were encountered: