Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align Close button behavior with adapt-close #50

Open
swashbuck opened this issue Sep 12, 2023 · 2 comments
Open

Align Close button behavior with adapt-close #50

swashbuck opened this issue Sep 12, 2023 · 2 comments
Assignees
@joe-allen-89
Labels
enhancement New feature or request

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Sep 12, 2023 •
edited
Loading

Subject of the issue

The Close button behavior should be aligned with the adapt-close extension.
@swashbuck swashbuck mentioned this issue Sep 12, 2023
Closed
@swashbuck swashbuck added the enhancement New feature or request label Oct 3, 2023
@oliverfoster
Copy link
Member

In what senses?

@swashbuck
Copy link
Contributor Author

The Close button has some additional features like a confirmation popup. In a recent meeting, I believe we had agreed to mirror the Close button behavior in Page Nav.

@joe-allen-89 joe-allen-89 self-assigned this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joe-allen-89 joe-allen-89

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

issue/50 cgkineo/adapt-pageNav
3 participants
@swashbuck @oliverfoster @joe-allen-89